Skip to content

[OTAGENT-665] Re-enable load balancing e2e test#43319

Merged
dd-mergequeue[bot] merged 4 commits intomainfrom
stanley.liu/load-balancing-flake
Dec 16, 2025
Merged

[OTAGENT-665] Re-enable load balancing e2e test#43319
dd-mergequeue[bot] merged 4 commits intomainfrom
stanley.liu/load-balancing-flake

Conversation

@liustanley
Copy link
Contributor

@liustanley liustanley commented Nov 20, 2025 •
edited
Loading

What does this PR do?

Re-enable load balancing e2e test

Motivation

Describe how you validated your changes

Removed skip and observed that flake was no longer occurring

Additional Notes

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 20, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 20, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d1bd251

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0}$$ $${706.33}$$ < $${707.13}$$ $${-0}$$ $${173.26}$$ < $${174.16}$$
✅ agent_deb_amd64_fips $${+0}$$ $${702.55}$$ < $${702.86}$$ $${+0.01}$$ $${172.62}$$ < $${173.5}$$
✅ agent_heroku_amd64 $${0}$$ $${327.51}$$ < $${327.92}$$ $${-0}$$ $${87.23}$$ < $${88.21}$$
✅ agent_msi $${0}$$ $${570.41}$$ < $${982.08}$$ $${0}$$ $${142.48}$$ < $${143.49}$$
✅ agent_rpm_amd64 $${+0}$$ $${706.32}$$ < $${707.12}$$ $${+0.01}$$ $${176.41}$$ < $${177.29}$$
✅ agent_rpm_amd64_fips $${+0}$$ $${702.54}$$ < $${702.85}$$ $${+0.01}$$ $${175.43}$$ < $${176.32}$$
✅ agent_rpm_arm64 $${+0}$$ $${688.02}$$ < $${691.67}$$ $${-0.02}$$ $${159.42}$$ < $${160.7}$$
✅ agent_rpm_arm64_fips $${+0}$$ $${685.06}$$ < $${687.54}$$ $${-0.02}$$ $${159.17}$$ < $${160.11}$$
✅ agent_suse_amd64 $${+0}$$ $${706.32}$$ < $${707.12}$$ $${+0.01}$$ $${176.41}$$ < $${177.29}$$
✅ agent_suse_amd64_fips $${+0}$$ $${702.54}$$ < $${702.85}$$ $${+0.01}$$ $${175.43}$$ < $${176.32}$$
✅ agent_suse_arm64 $${+0}$$ $${688.02}$$ < $${691.67}$$ $${-0.02}$$ $${159.42}$$ < $${160.7}$$
✅ agent_suse_arm64_fips $${+0}$$ $${685.06}$$ < $${687.54}$$ $${-0.02}$$ $${159.17}$$ < $${160.11}$$
✅ docker_agent_amd64 $${+0}$$ $${768.57}$$ < $${769.38}$$ $${+0}$$ $${261.17}$$ < $${262.06}$$
✅ docker_agent_arm64 $${+0.01}$$ $${774.83}$$ < $${778.35}$$ $${-0.02}$$ $${250.25}$$ < $${251.72}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${959.45}$$ < $${960.26}$$ $${+0}$$ $${329.8}$$ < $${330.69}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${954.41}$$ < $${957.95}$$ $${-0}$$ $${314.89}$$ < $${316.35}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${179.41}$$ < $${179.56}$$ $${-0}$$ $${63.44}$$ < $${64.14}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${195.36}$$ < $${196.79}$$ $${-0}$$ $${59.75}$$ < $${60.69}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.13}$$ < $${7.18}$$ $${+0}$$ $${2.99}$$ < $${3.33}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.73}$$ < $${3.09}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.75}$$ < $${39.38}$$ $${+0}$$ $${15.0}$$ < $${15.82}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.06}$$ < $${37.94}$$ $${+0}$$ $${14.33}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${+0}$$ $${7.93}$$ < $${8.79}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${28.13}$$ < $${29.11}$$ $${-0}$$ $${6.81}$$ < $${7.71}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.8}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.8}$$
✅ iot_agent_deb_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.19}$$ < $${12.04}$$
✅ iot_agent_deb_arm64 $${0}$$ $${39.87}$$ < $${40.92}$$ $${-0}$$ $${9.57}$$ < $${10.45}$$
✅ iot_agent_deb_armhf $${0}$$ $${40.44}$$ < $${41.03}$$ $${+0}$$ $${9.76}$$ < $${10.62}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$
✅ iot_agent_suse_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 20, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 812300f7-7922-4224-bb65-5ab6305efbd8

Baseline: d1bd251
Comparison: 74656cf
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.25 [-1.79, +4.29] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.25 [-1.79, +4.29] 1 Logs
➖ quality_gate_logs % cpu utilization +1.16 [-0.33, +2.64] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_delta memory utilization +0.68 [+0.47, +0.89] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.45 [+0.37, +0.53] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.41 [+0.35, +0.46] 1 Logs
➖ otlp_ingest_logs memory utilization +0.34 [+0.24, +0.44] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.21 [-0.00, +0.43] 1 Logs bounds checks dashboard
➖ file_to_blackhole_100ms_latency egress throughput +0.06 [+0.01, +0.11] 1 Logs
➖ docker_containers_memory memory utilization +0.05 [-0.03, +0.12] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.11, +0.14] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.38, +0.40] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.07, +0.08] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.41, +0.42] 1 Logs
➖ file_tree memory utilization -0.01 [-0.06, +0.05] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.01 [-0.17, +0.14] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.14, +0.12] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.03 [-0.26, +0.19] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization -0.06 [-0.21, +0.10] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.06 [-0.44, +0.32] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.06 [-0.10, -0.02] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.19 [-0.23, -0.15] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization -0.33 [-0.39, -0.26] 1 Logs
➖ ddot_metrics memory utilization -0.44 [-0.67, -0.22] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@liustanley liustanley changed the title WIP load balancing e2e flake [OTAGENT-665] Re-enable load balancing e2e test Dec 16, 2025
@liustanley liustanley added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation qa/skip-qa team/opentelemetry-agent labels Dec 16, 2025
@liustanley liustanley marked this pull request as ready for review December 16, 2025 16:47
@liustanley liustanley requested a review from a team as a code owner December 16, 2025 16:47
@liustanley liustanley requested a review from truthbk December 16, 2025 16:47
@liustanley liustanley added this to the 7.75.0 milestone Dec 16, 2025
@liustanley
Copy link
Contributor Author

liustanley commented Dec 16, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 16, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-16 21:19:57 UTC ℹ️ Start processing command /merge

2025-12-16 21:20:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 53m (p90).

2025-12-16 22:37:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2ba0d4c into main Dec 16, 2025
314 of 317 checks passed
@dd-mergequeue dd-mergequeue bot deleted the stanley.liu/load-balancing-flake branch December 16, 2025 22:37
mwdd146980 pushed a commit that referenced this pull request Dec 23, 2025
@liustanley @mwdd146980
[OTAGENT-665] Re-enable load balancing e2e test (#43319)
ef75a91 
### What does this PR do?
Re-enable load balancing e2e test

### Motivation

### Describe how you validated your changes
Removed skip and observed that flake was no longer occurring

### Additional Notes

Co-authored-by: stanley.liu <stanley.liu@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@songy23 songy23 songy23 approved these changes

@truthbk truthbk Awaiting requested review from truthbk truthbk is a code owner automatically assigned from DataDog/opentelemetry-agent

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation qa/skip-qa short review PR is simple enough to be reviewed quickly team/opentelemetry-agent

Projects

None yet

Milestone

7.75.0

Development

Successfully merging this pull request may close these issues.

2 participants

@liustanley @songy23